April-June is the most scenic time as the Sierra snow is melting and the falls are blasting.
Yosemite is packed with visitors almost all year round, perhaps except December and January. If you’re visiting during weekends or holidays, arrive at the parking by 8 AM to guarantee a spot near the attractions.